D Sparkles, hi. It seems you want to know if the approach you are taking, telling employers up front about your visa, is the best way to go for finding a job. Well, there aren't a lot of other options available, other than one. You can tell the employers nothing about your situation until later on in the hiring process. There's only two choices.
Based on that, I would ask two questions, and pull three cards (or four or two, etc.) for each question.
Question 1: How successful will my job search be if I tell employers right away that I am on a visa?
Question 2: How successful will my job search be and if don't tell them until later?
Then do a comparison between the two groups of cards. Look at which group seems to be happier. This will likely answer the issue for you and let you know what to do.
And good luck job hunting. I know how exhausting it can be.
